Hacker News

arm32
Ask HN: Is your leadership pushing you to skip dev review?

Noticing this throughout the industry, wondering how common it is.


muzani2 hours ago

I haven't seen it happen. They're the bottleneck now, and for some people, removing the bottleneck may mean removing the process. But there's probably a good reason why it's the bottleneck.

Some people think that as long as it passes all tests, that's all jolly - but it still needs a code review to check whether all the tests are still relevant and whether everything that needs to be tested is tested.

Even if AI gets the PRD 100% right, the PRD may be wrong. Getting the communications right is the essence of software engineering in the end.

is_the_grass_gr11 hours ago

Not leadership as much as the other developers! Leadership is open but concerned about SOC 2 compliance.

The other devs have already torpedoed standups and now no one wants to code review anymore. I'm sitting here remembering at the start of my career how people had to advocate for version control and code review and now my head is spinning because we're about to abandon it in favor of AI writing the code and AI reviewing it.

I maintain that code review is about having one another's back more than being a hoop to jump through, and that the rest of the folks in the employ of the company depend on our diligence. But I also am keeping note that all the "fixes" are on the reviewers side rather than the onus being on the dev requesting review. In my opinion, it's easier than ever to make a clean branch with clear atomic commits with good commit messages, and not knowing how to rebase is no longer an issue. But still the PRs are messy and large.

booyashaka133710 hours ago

I'm at a small company:

Our leadership is not pushing us to skip dev review. We have AI coding guidelines where engineers are trusted to merge in pull requests with no review if they pass certain criteria. Our code reviews are more so reviewing architectural docs, plans, evaluation criteria, etc. that an AI would then write the code for later.

lilnickyai6 hours ago

I have found that skipping review rarely saves time in the end, because small misunderstandings about requirements or edge cases tend to surface later when they are more expensive to fix. What has worked better in my experience is keeping reviews small and focused: short pull requests, a clear description of what changed and why, and automated tests for the routine checks. That way the human review can focus on logic and risk rather than style, and it stays fast enough that teams are less tempted to skip it.

maksburov2211 hours ago

[flagged]

hn-front (c) 2024 voximity
source