jorams11 hours ago
This is a weird post to be honest. You've found a whole bunch of serious security issues, filed two PRs, one of which is adding some quotes because
> Those aren't exploitable XSS, but it doesn't hurt to have a second layer of defense.
The other suggests breaking clients that aren't using the more secure version of an OAuth method because
> I can't think of any OAuth client that would like to [use it]
That second one is a good idea, but the maintainer is also right to ask for some discussion before introducing a breaking change.
But crucially: neither of these are the kind of significant security issues you've found. Maybe lead with an actual bug?
bogwog9 hours ago
And attempting to publicly shame them into accepting a PR. Kinda reminds me of https://en.wikipedia.org/wiki/XZ_Utils_backdoor
PunchyHamster10 hours ago
> That second one is a good idea, but the maintainer is also right to ask for some discussion before introducing a breaking change.
The discussion seems to be already happening https://codeberg.org/forgejo/forgejo/issues/8634, author of the blog just did drive-by PR rather than looking at issue tracker
It's very much "I know better, do what I told you despise not thinking a second about any second order effects the change might cause" attitude that is so common with security people
henryteeare10 hours ago
I believe the discussion in #8634 is for a different change, but one of a similar nature.
unethical_ban9 hours ago
Yeah, ITOps and software teams are totally aware of the second order effects of their shitty software and compliance failures, security are always the wrong ones.
arcfour10 hours ago
Closing the PR without providing feedback beyond "needs further discussion" does not engender said further discussion.
PunchyHamster10 hours ago
PR isn't a place for discussion about what or how to implement change in the first place, that should be forum/mailing list/issues
and there is open issue for that discussion https://codeberg.org/forgejo/forgejo/issues/8634
henryteeare10 hours ago
The response was, "needs a discussion," as in a post on `https://codeberg.org/forgejo/discussions`, rather than directly creating a PR.
There also was feedback saying approximately that they've been burned by security changes in the recent past and don't want to run into similar issues without due consideration.
preinheimer11 hours ago
There’s an old cryptography story.
A cryptographer friend tells the story of an amateur who kept bothering him with the cipher he invented. The cryptographer would break the cipher, the amateur would make a change to “fix” it, and the cryptographer would break it again. This exchange went on a few times until the cryptographer became fed up. When the amateur visited him to hear what the cryptographer thought, the cryptographer put three envelopes face down on the table. “In each of these envelopes is an attack against your cipher. Take one and read it. Don’t come back until you’ve discovered the other two attacks.” The amateur was never heard from again.
https://www.schneier.com/crypto-gram/archives/1998/1015.html
neilv11 hours ago
And if you are a dishonest cryptographer, you only need to find one attack to pull this off.
isodev10 hours ago
This entire post reads as rage bait. They’re mad because Forgejo has … a process? And what are these vulnerabilities, concretely?
> But given the sorry state of the codebase
I honesty want a refund on the 10 minutes I wasted reading this.
flumpcakes10 hours ago
Did the author actually disclose this RCE or just open random PRs and claim there's an issue?
It doesn't appear like the author is acting in good faith, instead grandstanding in public because they feel superior.
apublicfrog10 hours ago
The author quite clearly outlines their reasoning for this in the article:
> Carrot Disclosure, dangling a metaphorical carrot in front of the vendor to incentivise change. The main idea is to only publish the (redacted) output of the exploit for a critical vulnerability, to showcase that the software is exploitable. Now the vendor has two choices: either perform a holistic audit of its software, fixing as many issues as possible in the hope of fixing the showcased vulnerability; or losing users who might not be happy running a known-vulnerable software. Users of this disclosure model are of course called Bugs Bunnies.
flumpcakesan hour ago
Seems like grandstanding bad faith to me. They didn't even bother to follow the established disclosure policy for this project because the author feels this quality of the code is so crap, so instead does this...
jeremiahlee2 hours ago
The author sent 5 more pull requests fixing (tragically) fundamental security flaws. https://codeberg.org/forgejo/forgejo/pulls?q=&type=all&sort=...
pabs33 hours ago
I note that the code that pull request 12283 is changing builds HTML via string concatenation/templates, which is a widespread source of XSS problems. Maybe it is time to for browsers and JavaScript runtimes/libraries to deprecate string based HTML building and require DOM based instead. The former is unsafe by design and the latter is a safe-by-construction approach.
Getting HTML building right is a pretty basic building block of web apps, Forgejo can't have great security practices if they aren't doing that. So I can easily imagine the OP is correct in their assessment of Forgejo code security.
throwaway382949 hours ago
I run a forgejo instance at home but wouldn't dream of opening it up to the public. Works great, and fast on lan, but imo keep it there
gchamonlive10 hours ago
In the age of AI, carrot disclosure is potentially a full disclosure with extra steps. I'm no security expert, but with the context provided, the forgejo codebase and the outline of the redacted script, I think there is a good chance I could use codex to crunch through the vuln chain and reproduce the script.
nine_k10 hours ago
Where's the vuln chain? Is it even obvious which APIs have been called?
000ooo00011 hours ago
Hopefully someone a little more.. pragmatic gets eyes on that linked PR.
mmsc11 hours ago
https://codeberg.org/forgejo/governance/src/commit/5c07b3801...
> Failure to comply with these rules will be criticized publicly, and we reserve the right to no longer coordinate with you or your project in the future.
lol
stock_toaster10 hours ago
I could totally imagine this kind of thing being added due to AI-slop security report overload, like curl was experiencing[1].
[1]: https://daniel.haxx.se/blog/2025/07/14/death-by-a-thousand-s...
kasdklasmdads8 hours ago
Imagine if every open source contributor behaved like that.
"I found performance problems in your software, but I won't disclose them until you fix them."
"I'm a designer, but I won't disclose my improvement to your project until you adjust all the CSS bugs in your project."
If that person is skilled with finding security bugs, then that could be their contribution to that open-source project, like any other contribution.
unethical_ban11 hours ago
From a linked PR (related to this RCE?), from a maintainer who closed it:
>Just thinking something not being used is not enough, even if it's a security sensitive topic
Linux kernel seems to disagree. This is a dangerously naive way to think of networked software in the AI age.
---
edit: I got hit with the "posting too fast" block again, so I'll reply to dangus here:
>While a remote host would further prove the claim, the person clearly claims it is RCE, not just CE. It would be quite the pie in the face if the author wrote a python script to take in an IP address but modified system files on the backend to create a stunt.
dangus11 hours ago
It would definitely be a bit silly for the author to make a fake carrot disclosure, but I thought of it just because of how reading this article made me feel distrust toward the author. IDK, they just seem like kind of a jerk!
Now, I don't think the PRs with the Forgejo folks show a lot of warm collaborative energy on their side, either, but I can see how soft skills from the author would likely have taken their PRs a lot further in getting what they want.
But the author's whole attitude is that Forejo is such a mess and it's barely worth their time to try and clean it up. Nobody's twisting their arm to contribute to an open source project that they don't even like!
From the perspective of Forgejo maintainers, the author is just some random new contributor barging in and telling them to drop some legacy support that hasn't been discussed in detail yet. And of course, this new contributor hasn't actually followed the security policy to disclose it as a high severity issue to justify the change.
JuniperMesos10 hours ago
> But the author's whole attitude is that Forejo is such a mess and it's barely worth their time to try and clean it up. Nobody's twisting their arm to contribute to an open source project that they don't even like!
> From the perspective of Forgejo maintainers, the author is just some random new contributor barging in and telling them to drop some legacy support that hasn't been discussed in detail yet. And of course, this new contributor hasn't actually followed the security policy to disclose it as a high severity issue to justify the change.
It does affect my own willingness to use Forgejo, as a current non-user. It sounds like it has some security vulnerabilities that the maintainers aren't taking seriously, perhaps because they think the people who report those vulnerabilities are jerks. Are the Forgejo maintainers themselves sure that their software isn't going to get pwned in a way they don't have the right techniques to mitigate? I'd rather know that before I run it on my own infra.
jorams10 hours ago
> It sounds like it has some security vulnerabilities that the maintainers aren't taking seriously
It may, and they may or may not, but the author hasn't actually reported any. They're explicitly ignoring the security policy and vagueposting instead.
dangus9 hours ago
The author of this blog post essentially never reported the exploit to the Forgejo maintainers. They merely submitted a security-related PR.
The maintainers aren't mind readers. They have never been directly informed that a proven exploit exists, and the author of the article actively ignored the project's reporting process despite being aware of it.
And it's not a particularly complicated report process. You literally just email them.
chillfox11 hours ago
Don’t forget, repeatedly ignoring the requirements for including tests, and instead offering up a “have tested it locally, trust me” as a substitute.
conartist611 hours ago
The worry here is that they need to leave the security hole open because they're using it?
conartist611 hours ago
Idunno, I think this model of disclosure feels more natural to me. The "coordinated" model can have the smack of extortion to it.
And yes, I very much want there to exist people whose specialty is finding security bugs. I wouldn't expect such a person to be a diehard contributor to any particular project. Their motivation isn't making one tool better, but keeping users safe. We need those people and the work they do badly!
gbraad8 hours ago
This is so wrong. Because he didn't like a PR removing a feature, and they haven't yet merged another PR that was opened yesterday?!?
dangus11 hours ago
The author's attitude is so off-putting. What gives? Did Forgejo hurt you?
The Forgejo disclosure process looked pretty simple and straightforward to me. The bold and all-caps words that bothered the author are just making sure you know how to disclose vulnerabilities safely without leaking zero-day exploits to a wider audience than necessary.
I'm also not impressed with a carrot disclosure that looks like this. Running a python script to compromise a locally hosted instance? Bruh, you have physical hardware and host shell access. That python script could be doing anything including running as root.
Show us the exploit hitting a remote server.
quectophoton10 hours ago
> I'm also not impressed with a carrot disclosure that looks like this. Running a python script to compromise a locally hosted instance? Bruh, you have physical hardware and host shell access. That python script could be doing anything including running as root.
> Show us the exploit hitting a remote server.
Watch out, their script works on HN too, as a proof here's me logging in to YOUR computer's root account (a bit more redacted for obvious reasons):
$ python3 ./poc/chain_alpha.py --target dangus > out.txt
$ grep Backdoor out.txt | sed -r 's@[^:]+$@ [REDACTED]@g'
[+] Backdoor admin created: [REDACTED]
$ grep IP out.txt | sed -r 's@[^:]+$@ [REDACTED]@g'
[+] IPv4 address for dangus: [REDACTED]
$ grep 'debug2: shell' out.txt
[+] debug2: shell request accepted on channel 0
$ tail -n12 out.txt
================================================================
[+] COMMAND EXECUTION CONFIRMED!
================================================================
Server-side output (received via SSH, with `set -x`):
+ id -u
0
+ id -g
0
================================================================
$ sha256 ./poc/chain_alpha.py
c10d28a5ff74646683953874b035ca6ba56742db2f95198b54e561523e1880d7 ./poc/chain_alpha.pyshimman11 hours ago
Seriously, this author comes across as an absolute sore loser if this is the PR they are referring too:
https://codeberg.org/forgejo/forgejo/pulls/12283
Someone asking you to write a test for new code and then making this blog in response is just so pathetic.
martey11 hours ago
While I agree with you that this blog post (and the "carrot disclosure" described in it) is ill-considered, the pull request is not really "new code", it adds quotes to HTML attributes that are missing them. I think it's entirely reasonable for a contributor to assume that a new test case would not be needed for this small change, and that the maintainer's response ("So a simple question: is this code covered under a test? If not, you will have to add one.") is more abrasive than necessary.
preisschild2 hours ago
a test is probably not the right thing for this, but adding a linting rule so that quoting is enforced everywhere is probably the right way to go
onedognight11 hours ago
To hell with writing a test for you. That’s what you say to someone who gets paid by you. If the project doesn’t want the fix. That’s their issue, not the reporter’s.
akoboldfrying9 hours ago
Look at the big picture. The maintainers likely deal with many low-quality bug reports and PRs coming in, especially from AI, and the incentive to spam these is not going away anytime soon. How should they best allocate their limited attention?
One way is for the PR maker to signal their own attention to detail/effort/commitment by jumping through the (quite reasonable) hoop of writing a test.
Is this extra effort? Yes. But if your motivation in opening the PR in the first place is genuinely to improve the world, then do the slightly harder thing that actually improves the world given the constraints on maintainer attention it operates under, not the thing that is slightly easier for you but leaves your contribution indistinguishable from the sea of slop out there.
Chris204810 hours ago
> Someone asking you to write a test for new code
per the response: "I'm not sure what kind of test would you like me to write for this change, as it's simply adding 4 quotes"
kstrauser9 hours ago
Maybe one showing that the change doesn't make it worse. Here's the code change:
- <a class="item muted sidebar-item-link" href=${$(this).data('href')}>
+ <a class="item muted sidebar-item-link" href="${$(this).data('href')}">
<a class="item muted sidebar-item-link" href="https://example.com">
<a class="item muted sidebar-item-link" href=""https://example.com"">
MajesticHobo29 hours ago
I'd say also add a test that shows the HTML injection (which spurred the PR) isn't possible. Given an attacker-controlled URL of:
foo onclick
<a class="item muted sidebar-item-link" href=foo onclick>
<a class="item muted sidebar-item-link" href="foo onclick">kstrauser8 hours ago
Oh, for sure! That'd end the conversation: "your change breaks the existing tests. Fix that and we'll re-consider."
pabs32 hours ago
I wonder why they didn't change it to use DOM APIs instead. Related comment:
shimman9 hours ago
That totally justifies the very normal extortion like blog post in response.